Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-407] add document namespace to unknown types in external packa… #474

Merged
merged 1 commit into from
Feb 15, 2023
Merged

[issue-407] add document namespace to unknown types in external packa… #474

merged 1 commit into from
Feb 15, 2023

Conversation

meretp
Copy link
Collaborator

@meretp meretp commented Feb 10, 2023

…ge references
According to the spec:

The referenceType value for a non-listed location consists of the SPDX document namespace (see 6.5) followed by a # and the category as defined in 7.21.

addition to #448

Signed-off-by: Meret Behrens meret.behrens@tngtech.com

@meretp
[issue-407] add document namespace to unknown types in external packa…
5cd6452 
…ge references

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
maxhbr
maxhbr approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meretp meretp merged commit 20b80dc into spdx:refactor-python-tools Feb 15, 2023
@meretp meretp deleted the issue-407-fix-package-writer branch February 15, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meretp @maxhbr