allow and, or and with operators
#892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvr
requested changes
Mar 7, 2024
| @@ -27,10 +27,16 @@ compound-expression = (simple-expression / | |||
|
|
|||
| simple-expression "WITH" addition-expression / | |||
|
|
|||
| simple-expression "with" addition-expression / | |||
There was a problem hiding this comment.
please group the two versions in a single line:
simple-expression ( "WITH" / "with" ) addition-expression
| @@ -50,7 +56,7 @@ In the `tag:value` format, a license expression MUST be on a single line, and MU | |||
|
|
|||
| ## D.2 Case sensitivity <a name="D.2"></a> | |||
|
|
|||
| License expression operators (`AND`, `OR` and `WITH`) should be matched in a *case-sensitive* manner. | |||
| License expression operators (`AND`, `and`, `OR`, `or`, `WITH` and `with`) should be matched in a *case-sensitive* manner. I.e., variations `And`, `oR` are not allowed. | |||
There was a problem hiding this comment.
I don't think the final explanation is needed.
If we want to have it in, reword it to something like:
manner, i.e., letters must be all upper case or all lower case.
This is follow up of discussion https://lists.spdx.org/g/spdx/message/1798 where this was found as good compromise https://lists.spdx.org/g/spdx/message/1817 Signed-off-by: Miroslav Suchý <msuchy@redhat.com>
|
Updated. |
|
ping. @zvr can you please re-review? |
zvr
approved these changes
Mar 27, 2024
|
Oh thank you for this! 🎉 |
Conan-Kudo
approved these changes
Mar 27, 2024
goneall
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up of discussion https://lists.spdx.org/g/spdx/message/1798 where this was found as good compromise https://lists.spdx.org/g/spdx/message/1817
And followup of #876