Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples with correct referenceType for purl #800

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

goneall
Copy link
Member

@goneall goneall commented Oct 13, 2022

Fixes #799

Signed-off-by: Gary O'Neall gary@sourceauditor.com

Fixes #799

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Copy link

@nicoweidner nicoweidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenceTypes are fixed, thanks!
It looks like the rdf example was renamed to SPDXJSONExample-... - that's probably by mistake?
Finally, there are loads of changes in the rdf. Not sure why (maybe different tool version?), but I didn't really look at those.

@goneall
Copy link
Member Author

goneall commented Oct 17, 2022

It looks like the rdf example was renamed to SPDXJSONExample-... - that's probably by mistake?

Yes - that was an error - I'll add a commit to rename.

Finally, there are loads of changes in the rdf. Not sure why (maybe different tool version?), but I didn't really look at those.

This is an issue with the Jena library we use to serialize the RDF. It tends to resort everything making it very difficult to diff/compare. I wonder if there is a way to declare some ordering which would make the diffs easier - we probably aren't the first people to run into this.

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall merged commit a66a8df into development/v2.3.1 Oct 18, 2022
@goneall goneall deleted the issue799 branch October 18, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous referenceType in xml, rdf.xml and yaml examples
2 participants