Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "License Information in File" from License List Matching guidelines #1126

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 27, 2024

"License Information in File" field is no longer exist in SPDX 3.0.

Remove it from the matching guidelines, using a language suggested in #1125 (comment)

From:

To ensure consistent results by different SPDX document creators when matching license information that will be included in the License Information in File field.

To:

To ensure consistent results by different SPDX document creators when matching license information that will be included in SPDX data.

To fix #1125

…ist Matching guidelines

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-Authored-By: Alexios Zavras (zvr) <136705+zvr@users.noreply.github.com>
@bact bact added this to the 3.0.1 milestone Sep 27, 2024
@bact
Copy link
Collaborator Author

bact commented Sep 27, 2024

@swinslow please kindly review the change. Thank you.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bact - LGTM

@zvr
Copy link
Member

zvr commented Sep 28, 2024

Merging this; we can always fine-tune the language with a subsequent commit.

@zvr zvr merged commit d0c50d5 into spdx:development/v3.0.1 Sep 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A 2.x field is referenced in 3.0.1 License List matching guidelines (License Information in File)
3 participants