-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check examples are now failing #912
Comments
This was caused the the additional check added in PR #906 |
The failure is caused by sorta-malformed JSON in I recommend that we not look for documents to parse with grep, and instead list them specifically. I will post a PR to this effect shortly. |
The check assumes that JSON example snippets are all parts of a single JSON document that needs validating, but not all files are written that way. To avoid errors that have nothing to do with the correctness of the examples, we should only check files which meet the check's assumptions. Fixes spdx#912. Signed-off-by: Jeff Licquia <jeff@licquia.org>
The check assumes that JSON example snippets are all parts of a single JSON document that needs validating, but not all files are written that way. To avoid errors that have nothing to do with the correctness of the examples, we should only check files which meet the check's assumptions. Fixes #912. Signed-off-by: Jeff Licquia <jeff@licquia.org>
The check assumes that JSON example snippets are all parts of a single JSON document that needs validating, but not all files are written that way. To avoid errors that have nothing to do with the correctness of the examples, we should only check files which meet the check's assumptions. Fixes spdx#912. Signed-off-by: Jeff Licquia <jeff@licquia.org> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
The check assumes that JSON example snippets are all parts of a single JSON document that needs validating, but not all files are written that way. To avoid errors that have nothing to do with the correctness of the examples, we should only check files which meet the check's assumptions. Fixes spdx#912. Signed-off-by: Jeff Licquia <jeff@licquia.org> Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
The check examples CI is failing with the following errors:
The text was updated successfully, but these errors were encountered: