generate-bindings: Rework for offline builds#20
Closed
Conversation
JPEWdev
force-pushed
the
generate-bindings
branch
2 times, most recently
from
82fe420 to
4a33e00
Compare
Reworks the way that generate-bindings works to make it more suitable
for offline builds. Specifically:
1) Re-write as a python script to make it easier to maintain
2) Download model files manually instead of having shacl2code do it
3) Add options to control when downloading occurs. Options are
"always", "never", and "if-missing".
4) Allow SPDX_PYTHON_MODEL_DOWNLOAD environment variable to control
when downloading occurs (so it can be set when building the python
package)
5) Move the script out of the "gen" directory to "scripts"
6) Ensure the script always produces output in the "gen" directory,
even if it is run from elsewhere.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
JPEWdev
force-pushed
the
generate-bindings
branch
from
4a33e00 to
b0c166f
Compare
Collaborator
Author
|
#19 is preferred |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the way that generate-bindings works to make it more suitable for offline builds. Specifically:
"always", "never", and "if-missing".
when downloading occurs (so it can be set when building the python
package)
even if it is run from elsewhere.