Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final change log update for v3.0.1 model #889

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 26, 2024

This PR will be merge when we are happy to freeze the 3.0.1 and make tag release of the 3.0.1 model.

See change log update for the spec at spdx/spdx-spec#1123

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added documentation Improvements or additions to documentation publishing Dependency for publishing final version of spec labels Sep 26, 2024
@bact bact added this to the 3.0.1 milestone Sep 26, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@zvr
Copy link
Member

zvr commented Oct 17, 2024

Converting to "draft" to prevent accidental merging, since the 3.0.1 will happen when we get the OMG feedback and incorporate whatever changes come up.

@zvr zvr marked this pull request as draft October 17, 2024 19:31
@bact bact mentioned this pull request Nov 14, 2024
@bact bact marked this pull request as ready for review November 14, 2024 19:23
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact
Copy link
Collaborator Author

bact commented Nov 15, 2024

(Mark as draft again to prevent merge until we decide to freeze. Was undrafted previously to merge changes from main.)

@bact bact marked this pull request as draft November 15, 2024 14:44
@kestewart
Copy link
Contributor

@bact - when will you feel comfortable moving this out of draft? I think we're getting ready to tag 3.0.1; and it would be good for this to be part of it.

@bact bact marked this pull request as ready for review November 15, 2024 16:29
@bact
Copy link
Collaborator Author

bact commented Nov 15, 2024

@kestewart I think it's ready. Just recently logged #908 and #913

The date in the file is now 2024-11-15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation publishing Dependency for publishing final version of spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants