Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change log for import property rename + modify an example #848

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 13, 2024

@goneall If you're agree with this, you can merge this suggestions to #847 and we can review them together there.

Alternatively, I can close this one and open a new PR to merge this to main branch insstead. Thank you.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bact - I'll go ahead and merge into the other PR

@goneall goneall merged commit f1fcbcb into spdx:imports-fix Aug 13, 2024
1 check passed
@bact bact deleted the imports-fix-update-changelog branch August 13, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants