Conversation
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
bact
added
enhancement
Supports improvements to the license parsing error handling. See spdx/Spdx-Java-Library#339 for reference.
Fixes #338 Dependes on updates to the SPDX Models versions 2 and 3 which add a new class "InvalidLicenseExpression" which is used to produce the errors. This changes the behavior of the license parser from throwing an exception to returning an InvalidLicenseExpression where the verify routine will return the error message.
There was a problem hiding this comment.
Disclaimer: I didn't actually try compiling and running this code.
This change seems pretty straightforward, though it does break backwards compatibility, so perhaps an update to the docs is worthwhile?
IIRC we don't (yet) create a GitHub release for each new version of the library, but perhaps that's worth considering, since that generates fairly reasonable releases notes automatically (even though they are otherwise not very useful in the Java/Maven ecosystem)?
We might also choose a PR naming convention that indicates whether a change is breaking or not (perhaps a [BREAKING CHANGE] suffix, or similar verbiage), since that would make the automated release notes more useful to consumers.
We do actually create GitHub releases in addition to the Maven releases. |
|
Ah ok. It must be filtered out by the GitHub mobile client. |
3 participants
Fixes #338
Dependes on updates to the SPDX Models versions 2 and 3 which add a new class "InvalidLicenseExpression" which is used to produce the errors.
This changes the behavior of the license parser from throwing an exception to returning an InvalidLicenseExpression where the verify routine will return the error message.