Add getProperty(propertyNamesList, defaultValue)#326
Merged
goneall merged 2 commits intospdx:masterfrom Dec 2, 2025
Merged
Conversation
Add a new method to return the value of the first found configuration property from a list of names. Can be useful to use with deprecated names. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
With this, the code in #325 can be something like this: List<String> properties = Arrays.asList(
"org.spdx.useJARLicenseInfoOnly",
"SPDXParser.OnlyUseLocalLicenses",
"OnlyUseLocalLicenses");
onlyUseLocalLicenses = Boolean.parseBoolean(Configuration.getInstance().getProperty(properties, "false")); |
goneall
approved these changes
May 5, 2025
Member
goneall
left a comment
goneall
left a comment
There was a problem hiding this comment.
This does improve the conciseness of the code
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
|
Alternatively, v2.0 of the library may provide a good opportunity to do some spring cleaning and remove the old / deprecated property names (making sure to mention this in the upgrade readme). v2.0 already breaks backwards compatibility in other ways, so I don't think this is unreasonable, and we may not have another opportunity to sort this out for quite some time (i.e. until v3.0 of the library). |
Member
|
Probably a bit late to do any breaking changes, so I'll go ahead and merge this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new method to return the value of the first found configuration property from a list of names.
Can be useful to use with deprecated names.