Conversation
bact
reviewed
Jan 8, 2025
Member
Author
|
Also fixes #275 |
pmonks
approved these changes
Jan 21, 2025
Collaborator
pmonks
left a comment
pmonks
left a comment
There was a problem hiding this comment.
I don't completely understand the problem, having not worked with SPDX models to date, but with that said the code changes themselves, in isolation, appear to me to be entirely reasonable and consistent with neighbouring code.
Member
Author
Sorry @pmonks - I made the comment in the wrong tab, can you comment on issue #237 - thanks |
Collaborator
|
@goneall done! And no worries - this code change seemed small enough that I didn't mind giving it an uninformed once-over. 😉 |
Required for compatibility in case the deprecated field is still in use
This update depends on new versions of the SPDX core library (1.0.0-RC2 or later) and the SPDX 3 Model (1.0.0-RC2 or later) Fixes #273
Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com> Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update depends on new versions of the SPDX core library (1.0.0-RC2 or later) and the SPDX 3 Model (1.0.0-RC2 or later)
Fixes #273