Use write locks in license store to avoid deadlocks#251
Merged
Conversation
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
pmonks
approved these changes
Sep 24, 2024
Collaborator
pmonks
left a comment
pmonks
left a comment
There was a problem hiding this comment.
I haven't run into this issue myself, so my familiarity with it is minimal, but this change looks fairly innocuous, and all of the unit tests pass for me locally (including the slow tests).
Given the potential for decreased performance in concurrent scenarios (and the fact that such aspects are difficult to test via unit tests), I'd suggest that this change be released in an alpha, beta, release candidate or similar, so that it can be tested in real world scenarios by consumers of the library (and given how large of a change v2.0.0 is, this is probably a good idea more generally anyway).
Member
Author
|
I'll go ahead and merge this in so it can get some early testing with the 2.0 spec updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250