ci: report start of ci back to gerrit with vote 0 #49
Conversation
it's nice for developer to see where ci is running and follow up
There was a problem hiding this comment.
Please remember that this will double the number of comments from spdk-bot. Which would pollute the normal view of Gerrit comments, with no way to filter out irrelevant ones. Besides that there are folks that like to digest the updates to patches via email, and would need to put up additional filters on top specifically for this comment.
While I'm sure there are some (myself included) that do eagerly await results, this might not be the best way to go about it. Previously we've had a status page outlining builds in progress.
Now since its all GH based, maybe lets points to specific places folks can look to for status - here. The lacking part there are names of the jobs, so maybe modifying names to match commit title would be better approach ?
| change_num="${{ fromJson(inputs.client_payload).change.number }}" | ||
| patch_set="${{ fromJson(inputs.client_payload).patchSet.number }}" | ||
|
|
||
| echo "Gerrit: <https://review.spdk.io/c/spdk/spdk/+/$change_num/$patch_set>" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
This line will just duplicate "Gerrit: ..." entry in Github summary. You probably did not intended to add it here.
I can take that on, and I already have an initial version on my fork, but no promises on ETA as I'm busy with other topics at the moment. |
| report-start-ci: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Report start of ci |
There was a problem hiding this comment.
So this step is now basically a copy of Report results from summary.yml workflow. Perhaps making this an action item (like checkout_gerrit for example) would make it easier to re-use?
it's nice for developer to see where ci is running and follow up