Added halide implementations for subset of npbench#8
Closed
lukastruemper wants to merge 2 commits intomainfrom
Closed
Added halide implementations for subset of npbench#8lukastruemper wants to merge 2 commits intomainfrom
lukastruemper wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
|
Not sure about this PR. Maybe nice but maybe not important now to include? Maybe find a better mechanism to run those benchmarks with the npbench infrastructure @tbennun good ideas? |
alexnick83
requested changes
May 4, 2022
Contributor
alexnick83
left a comment
There was a problem hiding this comment.
We should check Halide's Python bindings and see if we can integrate Halide that way with the rest of the benchmark. However, we can merge this for now. Can you please write concise documentation on how to run these benchmarks? Are the results directly comparable to those from the Python frameworks? Also, do we need these parrot images? I would prefer that we avoid adding large files to the repo.
f100fb8 to
75fa87c
Compare
6d15103 to
0c462e6
Compare
0c462e6 to
c070ebc
Compare
Contributor
Author
|
Implemented the python bindings: #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.