Skip to content

nest_state_subgraph without self-copies; remove_memlet_path without None connectors - #2714

Merged
acalotoiu merged 2 commits into
spcl:mainfrom
ThrudPrimrose:fix-nest-subgraph-self-copy
Oct 21, 2026
Merged

acalotoiu merged 2 commits into
spcl:mainfrom
ThrudPrimrose:fix-nest-subgraph-self-copy

Conversation

@ThrudPrimrose

Copy link
Copy Markdown
Collaborator

nest_state_subgraph added a redundant name -> name copy for an output already written by an access node of the same container, and remove_memlet_path asked an access node to drop a None connector, which warns. Both cases are now skipped, each covered by a test that fails on main.

Comment thread dace/sdfg/state.py
else:
other_outgoing = False
edge.src.remove_out_connector(edge.src_conn)
if edge.src_conn is not None:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid warnings in the terminal output

@acalotoiu acalotoiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acalotoiu
acalotoiu added this pull request to the merge queue Oct 21, 2026
Merged via the queue into spcl:main with commit 296bf45 Oct 21, 2026
17 checks passed
@acalotoiu
acalotoiu deleted the fix-nest-subgraph-self-copy branch October 21, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants