Repository navigation
[Fix for Big Fortran SDFGs] Fix/framecode allocation placement - #2640
Merged
Merged
Conversation
A transient sized by a symbol that an interstate edge assigns is allocated at the dominator of its accesses. When that dominator only dominates them and its only outgoing edge carries the assignment and enters a control flow region, the allocation was emitted at the start of the dominator, before the symbol was assigned, and the array got an undefined size. The block the edge leads to now allocates the data, and a control flow region allocates on entry what it is the scope of. The deallocation at a postdominating region was never emitted, so the array leaked. A region now deallocates on exit what it is the scope of.
…he way to its accesses
ThrudPrimrose
added a commit
that referenced
this pull request
Oct 3, 2026
ThrudPrimrose
added a commit
that referenced
this pull request
Oct 3, 2026
A size scalar used as an extent is read through a symbol on an interstate edge (one fresh symbol per shape), and size-1 dimensions are squeezed consistently through matmul, gemm and transpose. Allocation placement relies on #2640, so no extra bracketing pass is needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.