Skip to content

Conversation

ThrudPrimrose
Copy link
Collaborator

I have noticed that my implementation had issues in two cases:

  1. With NestedSDFGs, the pass would crash occasionally if it had to add new data types.
  2. a = dace.int64(b) + c would be correctly split into two tasklets, but the in connectors and connectivity of the new tasklet i_f64 = dace.int64(b) would be wrong.

Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phschaad phschaad added this pull request to the merge queue Sep 29, 2025
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
@phschaad phschaad added this pull request to the merge queue Oct 2, 2025
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2025
@phschaad phschaad added this pull request to the merge queue Oct 8, 2025
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants