Add "Resource" controller attribute #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freekmurze Any chances of getting this reviewed and possibly merged? Thanks a lot |
|
Thanks, could you also update the readme? |
|
Updated. Preview. |
|
Nice, maybe add a link to the resource controller section in the Laravel
docs, and the we’re done I think 👍
On Sat, 14 Aug 2021 at 20:10, Ostap Bregin ***@***.***> wrote:
Updated. Preview
<https://github.com/osbre/laravel-route-attributes/tree/controller-resource-attribute#resource-controllers>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADWEDLLJWNGCLB7WF4BNB3T42WPRANCNFSM5BVQHESQ>
.
--
Freek Van der Herten https://spatie.be +32 495 84 27 91
|
|
Updated. Lmk if that works. Just in case: would love to maintain a package or participate in any kind of internship / help with something for free |
|
Thanks for this PR. Here's a list of open issues that you could take a look at: https://github.com/issues?utf8=✓&q=is%3Aopen+is%3Aissue+user%3Aspatie+is%3Apublic+-label%3Aenhancement+ As for internships: we only offer that for people that have knowledge of Dutch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22 #43
✨ Progress
Let me know if I'm moving this PR in the right direction :) Thanks