Skip to content

Update README.md, docs and comment in config file #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 1, 2020
Merged

Update README.md, docs and comment in config file #1154

merged 4 commits into from
Dec 1, 2020

Conversation

@jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Dec 1, 2020

  • Update information about minimal required version of PHP and Laravel
  • Update links to Laravel documentation to point to latest version
  • Sending Slack notifications requires laravel/slack-notification-channel, which requires (in composer.json) guzzlehttp/guzzle. Comment in config file instructed to require both of them, and documentation didn't event mention laravel/slack-notification-channel. Fixed that!

@freekmurze freekmurze merged commit a860fc8 into spatie:master Dec 1, 2020
@freekmurze
Copy link
Member

freekmurze commented Dec 1, 2020

Thanks!

@jrmajor jrmajor deleted the update-readme branch December 1, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jrmajor @freekmurze