Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Brazilian Holidays #13

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Support for Brazilian Holidays #13

merged 2 commits into from
Jan 17, 2024

Conversation

devajmeireles
Copy link
Contributor

🥳

@Nielsvanpach Nielsvanpach merged commit ded94cd into spatie:main Jan 17, 2024
1 check passed
@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach
Copy link
Member

Hi @devajmeireles, it seems I merged this one too quickly. The tests on CI here are failing (they didn't run in the PR). Could you take a look?

@devajmeireles
Copy link
Contributor Author

Hi @devajmeireles, it seems I merged this one too quickly. The tests on CI here are failing (they didn't run in the PR). Could you take a look?

I updated my fork and ran the test again. I've noticed an exception in the Brazil class. After removing it and the skip of the test, the test passes successfully.

CleanShot 2024-01-18 at 07 52 25

@Nielsvanpach
Copy link
Member

Could you open a PR with the fix? I skipped the Brazil test on the main branch, as they are failing with Github Actions

@devajmeireles
Copy link
Contributor Author

Could you open a PR with the fix? I skipped the Brazil test on the main branch, as they are failing with Github Actions

Done! #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nielsvanpach Nielsvanpach Nielsvanpach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devajmeireles @Nielsvanpach