Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes #11

Merged
merged 1 commit into from
Aug 25, 2021
Merged

small fixes #11

merged 1 commit into from
Aug 25, 2021

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Aug 25, 2021

  • use isinstance instead of type
  • check shape of array in concentration heatmap image
  • removed unused imports

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #11 (cff2dd1) into master (df22b9c) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   85.16%   85.10%   -0.07%     
==========================================
  Files           2        2              
  Lines         236      235       -1     
  Branches       36       36              
==========================================
- Hits          201      200       -1     
  Misses         24       24              
  Partials       11       11              
Impacted Files Coverage Δ
sme_contrib/plot.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df22b9c...cff2dd1. Read the comment docs.

- use isinstance instead of type
- check shape of array in concentration heatmap image
- removed unused imports
- increase tolerance of minimize test
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lkeegan lkeegan merged commit 5cc546d into master Aug 25, 2021
@lkeegan lkeegan deleted the cleanup branch August 25, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant