Add multiple lifetimes tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmandry
requested changes
Feb 6, 2025
| } | ||
| impl<'dynosaur_struct> SomeTrait for DynSomeTrait<'dynosaur_struct> { | ||
| fn async_ret_impl_trait<'a, 'b>(&self, a: &'a u8, b: &'b u8) | ||
| -> impl ::core::future::Future<Output = impl Trait<'a, 'b>> { |
There was a problem hiding this comment.
This doesn't actually compile. Seems like async fn with RPITIT is not yet supported (fine).
I would like it if we built all tests in this directory.
spastorino
force-pushed
the
add-more-tests
branch
from
34da74e to
0016f04
Compare
spastorino
force-pushed
the
add-more-tests
branch
from
0016f04 to
d9fa389
Compare
tmandry
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @tmandry
This PR needs #46