Change struct representation to transparent #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmandry
requested changes
Aug 20, 2024
dynosaur/tests/pass/basic-mut.stdout
Outdated
Comment on lines
51
to
54
| pub fn boxed(value: impl MyTrait) | ||
| -> Box<DynMyTrait<'dynosaur_struct>> { | ||
| Self::new(Box::new(value)) | ||
| } |
tmandry
reviewed
Aug 20, 2024
dynosaur/tests/pass/basic-mut.stdout
Outdated
| } | ||
| pub fn new(value: Box<impl MyTrait>) | ||
| -> Box<DynMyTrait<'dynosaur_struct>> { | ||
| let value: Box<dyn ErasedMyTrait> = value; |
There was a problem hiding this comment.
I don't see how this could have compiled since it's implicitly Box<dyn ErasedMyTrait + 'static>. It would require that the parameter was Box<impl MyTrait + 'static>.
spastorino
force-pushed
the
change-struct-repr
branch
2 times, most recently
from
59f90cb to
d43be76
Compare
tmandry
approved these changes
Aug 21, 2024
spastorino
force-pushed
the
change-struct-repr
branch
from
d43be76 to
70f18a0
Compare
tmandry
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @tmandry