Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second commit #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

second commit #1

wants to merge 2 commits into from

Conversation

Takuma1111
Copy link
Collaborator

No description provided.

@@ -0,0 +1,56 @@
class TasksController < ApplicationController
def index
puts "called TasksController#index"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Takuma1111
不要なデバッグコードは削除しちゃいましょう!

else
flash.now[:alert] = @task.errors.full_messages
render :index
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Takuma1111
このへんのインデントも修正お願いします!

end

def show
@task = Task.find(params[:id])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Takuma1111
before_action使って処理をまとめてみて下さい!


@tasks = Task.all
render :index
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Takuma1111
このへんもインデント修正お願いします!

<% end %>
</ul>

________________________________________________

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Takuma1111
線を引く時は<hr>使いましょう!

@kazu-taka
Copy link

@Takuma1111
全体的にインデントや空行の確認お願いします!

@Takuma1111
Copy link
Collaborator Author

@kazu-taka befor_actionと


使いました!
controllerは全体的に間隔あけたほうがいいですかね

@kazu-taka
Copy link

@Takuma1111
コントローラの書き方は今の感じでOKです!
めちゃくちゃ綺麗になりましたね!

@kazu-taka
Copy link

@Takuma1111
ビューもコントローラと同じように、インデントの修正お願いします!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants