-
Notifications
You must be signed in to change notification settings - Fork 26
Fix listener added and removed wrong order #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listener added and removed wrong order #293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
- Coverage 90.90% 89.42% -1.49%
==========================================
Files 1 1
Lines 99 104 +5
Branches 32 33 +1
==========================================
+ Hits 90 93 +3
- Misses 7 8 +1
- Partials 2 3 +1
Continue to review full report at Codecov.
|
I'm assuming this solution works reliably? With both the physical escape key and the virtual one on the touch bar? |
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
Yes, the virtual escape key was not a specialized case but rather just an author catching the problem with a very specific scenario, the virtual escape key just fires the same event as the physical escape key. Besides that, I was not able to reproduce the bug after these changes, and it makes sense, with run to completion in mind, this approach will always detect if removal has happened before addition. |
All requested changes have been made
…and-removed-wrong-order Fix listener added and removed wrong order
This pull request adds a fix for event listeners that were being added and removed in the wrong order.
Closes #292