Skip to content

Commit

Permalink
pata_imx: Use devm_ioremap_resource() to simplify code
Browse files Browse the repository at this point in the history
Using devm_ioremap_resource() can lead to code simplication, as we don't need
to explicitily check for error returned by platform_get_resource().

Also, no need to print an error message when devm_ioremap_resource() fails,
as the OOM code code will shout loudly on such condition.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Fabio Estevam authored and htejun committed Feb 18, 2014
1 parent 1bc1808 commit b314fc7
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions drivers/ata/pata_imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ static int pata_imx_probe(struct platform_device *pdev)
struct resource *io_res;
int ret;

io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (io_res == NULL)
return -EINVAL;

irq = platform_get_irq(pdev, 0);
if (irq <= 0)
return -EINVAL;
Expand Down Expand Up @@ -133,10 +129,9 @@ static int pata_imx_probe(struct platform_device *pdev)
ap->pio_mask = ATA_PIO0;
ap->flags |= ATA_FLAG_SLAVE_POSS;

priv->host_regs = devm_ioremap(&pdev->dev, io_res->start,
resource_size(io_res));
io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
priv->host_regs = devm_ioremap_resource(&pdev->dev, io_res);
if (!priv->host_regs) {
dev_err(&pdev->dev, "failed to map IO/CTL base\n");
ret = -EBUSY;
goto err;
}
Expand Down

0 comments on commit b314fc7

Please sign in to comment.