Skip to content

Commit

Permalink
HID: remove compat stuff
Browse files Browse the repository at this point in the history
This removal was scheduled and there is no problem with later
distros to adapt for the new bus, thanks to aliases.

module-init-tools map files are deprecated nowadays, so that
the patch which introduced hid ones into the m-i-t won't be
accepted and hence there is no reason for leaving compat stuff in.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
jirislaby authored and Jiri Kosina committed Mar 30, 2009
1 parent b2ddd54 commit afa5eb7
Show file tree
Hide file tree
Showing 30 changed files with 0 additions and 195 deletions.
7 changes: 0 additions & 7 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,6 @@ Who: Glauber Costa <gcosta@redhat.com>

---------------------------

What: remove HID compat support
When: 2.6.29
Why: needed only as a temporary solution until distros fix themselves up
Who: Jiri Slaby <jirislaby@gmail.com>

---------------------------

What: print_fn_descriptor_symbol()
When: October 2009
Why: The %pF vsprintf format provides the same functionality in a
Expand Down
12 changes: 0 additions & 12 deletions drivers/hid/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,6 @@ source "drivers/hid/usbhid/Kconfig"
menu "Special HID drivers"
depends on HID

config HID_COMPAT
bool "Load all HID drivers on hid core load"
default y
---help---
Compatible option for older userspace. If you have system without udev
support of module loading through aliases and also old
module-init-tools which can't handle hid bus, choose Y here. Otherwise
say N. If you say N and your userspace is old enough, the only
functionality you lose is modules autoloading.

If unsure, say Y.

config HID_A4TECH
tristate "A4 tech" if EMBEDDED
depends on USB_HID
Expand Down
4 changes: 0 additions & 4 deletions drivers/hid/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ obj-$(CONFIG_HID) += hid.o
hid-$(CONFIG_HID_DEBUG) += hid-debug.o
hid-$(CONFIG_HIDRAW) += hidraw.o

ifdef CONFIG_HID_COMPAT
obj-m += hid-dummy.o
endif

hid-logitech-objs := hid-lg.o
ifdef CONFIG_LOGITECH_FF
hid-logitech-objs += hid-lgff.o
Expand Down
2 changes: 0 additions & 2 deletions drivers/hid/hid-a4tech.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,5 +158,3 @@ static void a4_exit(void)
module_init(a4_init);
module_exit(a4_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(a4tech);
2 changes: 0 additions & 2 deletions drivers/hid/hid-apple.c
Original file line number Diff line number Diff line change
Expand Up @@ -474,5 +474,3 @@ static void apple_exit(void)
module_init(apple_init);
module_exit(apple_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(apple);
2 changes: 0 additions & 2 deletions drivers/hid/hid-belkin.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,3 @@ static void belkin_exit(void)
module_init(belkin_init);
module_exit(belkin_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(belkin);
2 changes: 0 additions & 2 deletions drivers/hid/hid-cherry.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,3 @@ static void ch_exit(void)
module_init(ch_init);
module_exit(ch_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(cherry);
2 changes: 0 additions & 2 deletions drivers/hid/hid-chicony.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,3 @@ static void ch_exit(void)
module_init(ch_init);
module_exit(ch_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(chicony);
21 changes: 0 additions & 21 deletions drivers/hid/hid-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1819,15 +1819,6 @@ void hid_unregister_driver(struct hid_driver *hdrv)
}
EXPORT_SYMBOL_GPL(hid_unregister_driver);

#ifdef CONFIG_HID_COMPAT
static void hid_compat_load(struct work_struct *ws)
{
request_module("hid-dummy");
}
static DECLARE_WORK(hid_compat_work, hid_compat_load);
static struct workqueue_struct *hid_compat_wq;
#endif

static int __init hid_init(void)
{
int ret;
Expand All @@ -1842,15 +1833,6 @@ static int __init hid_init(void)
if (ret)
goto err_bus;

#ifdef CONFIG_HID_COMPAT
hid_compat_wq = create_singlethread_workqueue("hid_compat");
if (!hid_compat_wq) {
hidraw_exit();
goto err;
}
queue_work(hid_compat_wq, &hid_compat_work);
#endif

return 0;
err_bus:
bus_unregister(&hid_bus_type);
Expand All @@ -1860,9 +1842,6 @@ static int __init hid_init(void)

static void __exit hid_exit(void)
{
#ifdef CONFIG_HID_COMPAT
destroy_workqueue(hid_compat_wq);
#endif
hidraw_exit();
bus_unregister(&hid_bus_type);
}
Expand Down
2 changes: 0 additions & 2 deletions drivers/hid/hid-cypress.c
Original file line number Diff line number Diff line change
Expand Up @@ -154,5 +154,3 @@ static void cp_exit(void)
module_init(cp_init);
module_exit(cp_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(cypress);
2 changes: 0 additions & 2 deletions drivers/hid/hid-drff.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,5 +186,3 @@ static void __exit dr_exit(void)
module_init(dr_init);
module_exit(dr_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(dragonrise);
87 changes: 0 additions & 87 deletions drivers/hid/hid-dummy.c

This file was deleted.

2 changes: 0 additions & 2 deletions drivers/hid/hid-ezkey.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,3 @@ static void ez_exit(void)
module_init(ez_init);
module_exit(ez_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(ezkey);
2 changes: 0 additions & 2 deletions drivers/hid/hid-gaff.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,5 +181,3 @@ static void __exit ga_exit(void)
module_init(ga_init);
module_exit(ga_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(greenasia);
2 changes: 0 additions & 2 deletions drivers/hid/hid-gyration.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,3 @@ static void gyration_exit(void)
module_init(gyration_init);
module_exit(gyration_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(gyration);
2 changes: 0 additions & 2 deletions drivers/hid/hid-kensington.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,3 @@ static void ks_exit(void)
module_init(ks_init);
module_exit(ks_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(kensington);
2 changes: 0 additions & 2 deletions drivers/hid/hid-kye.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,3 @@ static void kye_exit(void)
module_init(kye_init);
module_exit(kye_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(kye);
2 changes: 0 additions & 2 deletions drivers/hid/hid-lg.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,5 +326,3 @@ static void lg_exit(void)
module_init(lg_init);
module_exit(lg_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(logitech);
2 changes: 0 additions & 2 deletions drivers/hid/hid-microsoft.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,5 +210,3 @@ static void ms_exit(void)
module_init(ms_init);
module_exit(ms_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(microsoft);
2 changes: 0 additions & 2 deletions drivers/hid/hid-monterey.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,3 @@ static void mr_exit(void)
module_init(mr_init);
module_exit(mr_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(monterey);
2 changes: 0 additions & 2 deletions drivers/hid/hid-ntrig.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,3 @@ static void ntrig_exit(void)
module_init(ntrig_init);
module_exit(ntrig_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(ntrig);
2 changes: 0 additions & 2 deletions drivers/hid/hid-petalynx.c
Original file line number Diff line number Diff line change
Expand Up @@ -118,5 +118,3 @@ static void pl_exit(void)
module_init(pl_init);
module_exit(pl_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(petalynx);
2 changes: 0 additions & 2 deletions drivers/hid/hid-pl.c
Original file line number Diff line number Diff line change
Expand Up @@ -230,5 +230,3 @@ static void pl_exit(void)
module_init(pl_init);
module_exit(pl_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(pantherlord);
2 changes: 0 additions & 2 deletions drivers/hid/hid-samsung.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,3 @@ static void samsung_exit(void)
module_init(samsung_init);
module_exit(samsung_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(samsung);
2 changes: 0 additions & 2 deletions drivers/hid/hid-sony.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,3 @@ static void sony_exit(void)
module_init(sony_init);
module_exit(sony_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(sony);
2 changes: 0 additions & 2 deletions drivers/hid/hid-sunplus.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,3 @@ static void sp_exit(void)
module_init(sp_init);
module_exit(sp_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(sunplus);
2 changes: 0 additions & 2 deletions drivers/hid/hid-tmff.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,5 +265,3 @@ static void tm_exit(void)
module_init(tm_init);
module_exit(tm_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(thrustmaster);
2 changes: 0 additions & 2 deletions drivers/hid/hid-topseed.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,3 @@ static void ts_exit(void)
module_init(ts_init);
module_exit(ts_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(topseed);
2 changes: 0 additions & 2 deletions drivers/hid/hid-zpff.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,5 +158,3 @@ static void zp_exit(void)
module_init(zp_init);
module_exit(zp_exit);
MODULE_LICENSE("GPL");

HID_COMPAT_LOAD_DRIVER(zeroplus);
16 changes: 0 additions & 16 deletions include/linux/hid.h
Original file line number Diff line number Diff line change
Expand Up @@ -792,21 +792,5 @@ dbg_hid(const char *fmt, ...)
__FILE__ , ## arg)
#endif /* HID_FF */

#ifdef __KERNEL__
#ifdef CONFIG_HID_COMPAT
#define HID_COMPAT_LOAD_DRIVER(name) \
/* prototype to avoid sparse warning */ \
extern void hid_compat_##name(void); \
void hid_compat_##name(void) { } \
EXPORT_SYMBOL(hid_compat_##name)
#else
#define HID_COMPAT_LOAD_DRIVER(name)
#endif /* HID_COMPAT */
#define HID_COMPAT_CALL_DRIVER(name) do { \
extern void hid_compat_##name(void); \
hid_compat_##name(); \
} while (0)
#endif /* __KERNEL__ */

#endif

0 comments on commit afa5eb7

Please sign in to comment.