Skip to content

Commit

Permalink
PCI: Use msix_table_size() directly, drop multi_msix_capable()
Browse files Browse the repository at this point in the history
The users of multi_msix_capable() are really interested in the table
size, so just say what we mean.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
bjorn-helgaas committed Apr 23, 2013
1 parent 909094c commit 527eee2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
7 changes: 5 additions & 2 deletions drivers/pci/msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@

static int pci_msi_enable = 1;

#define msix_table_size(flags) ((flags & PCI_MSIX_FLAGS_QSIZE) + 1)


/* Arch hooks */

#ifndef arch_msi_check_device
Expand Down Expand Up @@ -681,7 +684,7 @@ static int msix_capability_init(struct pci_dev *dev,
pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, control);

/* Request & Map MSI-X table region */
base = msix_map_region(dev, multi_msix_capable(control));
base = msix_map_region(dev, msix_table_size(control));
if (!base)
return -ENOMEM;

Expand Down Expand Up @@ -904,7 +907,7 @@ int pci_msix_table_size(struct pci_dev *dev)
return 0;

pci_read_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, &control);
return multi_msix_capable(control);
return msix_table_size(control);
}

/**
Expand Down
3 changes: 0 additions & 3 deletions drivers/pci/msi.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@
#define msi_mask_reg(base, is64bit) \
(base + ((is64bit == 1) ? PCI_MSI_MASK_64 : PCI_MSI_MASK_32))

#define msix_table_size(control) ((control & PCI_MSIX_FLAGS_QSIZE)+1)
#define multi_msix_capable(control) msix_table_size((control))

#endif /* MSI_H */

0 comments on commit 527eee2

Please sign in to comment.