Optimize the statement check for a non-discarded database #565
+45
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #564 which pointed out a performance regression from #558.
This also restores the ability (now tested!) to call
Database#close
successfully and defer its cleanup until afterStatement
s are closed, which was the promise of #557 andsqlite3_close_v2
.Running the benchmark @tenderlove wrote for #564:
On 480f3e7 after
sqlite3_open_v2
was introduced by #557:On 81ea485 after fork protection was introduced by #558, performance regressed:
On 56d47a6 in this PR, performance is restored.