Address `warning: mismatched indentations at 'when' with 'case' #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` /path/to/sqlite3-ruby/lib/sqlite3/pragmas.rb:26: warning: mismatched indentations at 'else' with 'case' at 23 /path/to/sqlite3-ruby/lib/sqlite3/pragmas.rb:34: warning: mismatched indentations at 'else' with 'case' at 21 ``` These mismatched indentations are corrected by RuboCop as follows. ``` $ rubocop --auto-correct --only Layout/ElseAlignment,Layout/CaseIndentation lib/sqlite3/pragmas.rb ``` https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/63141 relaxed the condition of this warning.
It is likely duplicate with travis-ci/travis-ci#8969
|
Updated the pull request since https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/63141 relaxed the condition of this warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request suppresses these warnings with
ruby 2.6.0dev (2018-04-07 trunk 63108) [x86_64-linux]Since Rails CI for railties with ruby-head gets failed https://travis-ci.org/rails/rails/jobs/363332680 due to
The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).I'd like to address this failure by reducing number of warnings. Here are sqlite3-ruby ones.