Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better defensive behavior when libxml2 or libxslt will make unsafe modifications to a document #2829

Merged
merged 4 commits into from
Mar 10, 2023
Merged

better defensive behavior when libxml2 or libxslt will make unsafe modifications to a document #2829

merged 4 commits into from
Mar 10, 2023

Commits on Mar 9, 2023

  1. fix: Schema.from_document defensively copies the document 

    when there are blank text node objects. previously we raised an
exception.
    @flavorjones
    flavorjones committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1b2b4be View commit details
    Browse the repository at this point in the history

  2. style: variable naming as a prefactor

    @flavorjones
    flavorjones committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e0bd4a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. fix: ensure XSLT.transform doesn't modify the original doc 

    which it does be default when xsl:strip-space is used

this approach makes a defensive copy of the doc if there's a chance
the original may be modified in an unsafe way:

- if any spaces will be stripped
- and there are blank node objects that might be removed

Fixes #2800
    @flavorjones
    flavorjones committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8054059 View commit details
    Browse the repository at this point in the history

  2. doc: update CHANGELOG for 2800

    @flavorjones
    flavorjones committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    cfbb42f View commit details
    Browse the repository at this point in the history