fix: fragment context parsing #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make sure the behavior of quirks mode matches the discussion at issue #2646.
flavorjones
force-pushed
the
2646-fix-fragment-context-parsing
branch
from
220d6b4
to
deaa9c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Fixes #2646.
This PR introduces:
HTML5::QuirksMode, an enumHTML5::Document#quirks_modeHTML5::DocumentFragment#quirks_modeIt also changes the behavior of the fragment parser to use the parent document's quirks mode, and default to
NO_QUIRKSin edge cases.Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
The HTML5 parser is only supported in CRuby.