Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: use xmlsec's noxxe entity loader #2654

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Sep 28, 2022

Draft PR to try to use xmlsec's noxxe entity loader when NONET is set -- thereby making NONET shut off not just network access, but all access to external resources.

See #1582 for context.

this segfaults with seed 12441 and I have not yet been able to track
it down
@flavorjones
Copy link
Member Author

flavorjones commented Sep 29, 2022

This branch has been segfaulting with seed 12441.

I've pushed a commit that resets the external entity loader before the call that was segfaulting (in the HTML4 SAX parser context) and the segfault stops.

This tells me that we're not resetting the loader state properly after every call, this may be another instance of problems caused by raising errors - see #1610 and #2096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant