dep: move dev dependencies into Gemfile #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pin the dev dependencies so that dependabot will tell us when new versions are out and we'll get CI results automatically. Make rubocop dependencies conditional on Ruby 3 to work around the constraint of rubocop-shopify requiring ruby 2.7 or higher. Bump rubocop versions and regenerate the rubocop TODO file.
flavorjones
force-pushed
the
flavorjones-move-dev-dependencies-into-gemfile
branch
from
31cf417 to
0c2d55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
I'd like dependabot to bump our dev dependencies, and get CI feedback, so this PR pins them to specific versions.
I'm moving these dependencies out of the gemspec and into
Gemfile, which I'm not confident is better, but does allow us to conditionally depend on rubocop only for Ruby 3+, unblocking the upgrade of rubocop-shopify (which deprecated support for Ruby 2.6) which is also in this PR, along with regenerating the rubocop TODO file.