dep: neko-htmlunit update to 2.63.0 #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to backport this, the v1.13.x branch is still using our fork of nekohtml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Since updating
mainto useneko-htmlunitfor the JRuby HTML4 parser, some tests related to error recovery were markedpending. I submitted a PR upstream at HtmlUnit/htmlunit-neko#13 to address this, and it was merged and released in v2.63.0.This PR updates the JRuby implementation to that version and un-pends the failing tests.
Have you included adequate test coverage?
Yes! Failing tests were pending and are now not-pending.
Does this change affect the behavior of either the C or the Java implementations?
This brings the Java implementation back in line with the C implementation, with respect to this particular error handling behavior.