HTML parse processing instructions (backport to v1.13.x) #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-parse-processing-instructions-v1.13.x
branch
3 times, most recently
from
825b08f to
4905a4d
Compare
so let's pick an unambiguously-inline element to test.
Added test coverage to describe behavior of our parsers, and update nekohtml to 1.9.22.noko2.
flavorjones
force-pushed
the
flavorjones-parse-processing-instructions-v1.13.x
branch
from
4905a4d to
0feac5a
Compare
flavorjones
deleted the
flavorjones-parse-processing-instructions-v1.13.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Add test coverage for HTML parsing of processing instructions, and update the packaged nekohtml library used for the JRuby implementation.
(backport to v1.13.x)
Have you included adequate test coverage?
Yes, additional coverage provided.
Does this change affect the behavior of either the C or the Java implementations?
The Java implementation is still different from the C implementation for HTML4, but test coverage describes those differences.