Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to libiconv 1.16 #2206

Closed
3 tasks done
flavorjones opened this issue Mar 14, 2021 · 0 comments · Fixed by #2312
Closed
3 tasks done

Upgrade to libiconv 1.16 #2206

flavorjones opened this issue Mar 14, 2021 · 0 comments · Fixed by #2312
Labels
vendored/iconv
Milestone
v1.13.0

Comments

@flavorjones
Copy link
Member

flavorjones commented Mar 14, 2021 •
edited
Loading

libiconv v1.16 was released in 2019. Nokogiri v1.8.0..v1.11.2 has been using libiconv v1.15.

Looking at the Changelog, there doesn't seem to be an urgent reason to upgrade, but we should generally try to stay current.

Note that libiconv is only used for precompiled libraries on these platforms:

  • macOS ("x86_64-darwin" and "arm64-darwin")
  • Windows ("x86-mingw32" and "x64-mingw32")

See LICENSE-DEPENDENCIES.md for more information.

Punchlist:

  • update the dependencies.yml file
  • test a Windows native gem built with it
  • test a macOS native gem built with it

See b788241 for prior update to v1.15, to see what changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vendored/iconv
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

dep: update libiconv to 1.16 sparklemotion/nokogiri
1 participant
@flavorjones