Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] java gems package C extension code #2099

Closed
flavorjones opened this issue Oct 14, 2020 · 1 comment
Closed

[bug] java gems package C extension code #2099

flavorjones opened this issue Oct 14, 2020 · 1 comment

Comments

@flavorjones
Copy link
Member

Please describe the bug

The java platform gems contain the C extension code. This is unnecessary and should be removed to make the gem file as small as possible.

Help us reproduce what you're seeing

$ gem fetch nokogiri --platform jruby -v 1.10.10
Downloaded nokogiri-1.10.10-java

$ tar -xvf nokogiri-1.10.10-java.gem 
metadata.gz
data.tar.gz
checksums.yaml.gz

$ tar -ztvf data.tar.gz | egrep "\.[ch]$"
-rw-r--r-- wheel/wheel    4500 2020-07-06 09:18 ext/nokogiri/html_document.c
-rw-r--r-- wheel/wheel     159 2020-07-06 09:18 ext/nokogiri/html_document.h
-rw-r--r-- wheel/wheel    5990 2020-07-06 09:18 ext/nokogiri/html_element_description.c
-rw-r--r-- wheel/wheel     202 2020-07-06 09:18 ext/nokogiri/html_element_description.h
-rw-r--r-- wheel/wheel     813 2020-07-06 09:18 ext/nokogiri/html_entity_lookup.c
-rw-r--r-- wheel/wheel     136 2020-07-06 09:18 ext/nokogiri/html_entity_lookup.h
-rw-r--r-- wheel/wheel    3079 2020-07-06 09:18 ext/nokogiri/html_sax_parser_context.c
-rw-r--r-- wheel/wheel     197 2020-07-06 09:18 ext/nokogiri/html_sax_parser_context.h
-rw-r--r-- wheel/wheel    2175 2020-07-06 09:18 ext/nokogiri/html_sax_push_parser.c
-rw-r--r-- wheel/wheel     184 2020-07-06 09:18 ext/nokogiri/html_sax_push_parser.h
-rw-r--r-- wheel/wheel    4302 2020-07-06 09:18 ext/nokogiri/nokogiri.c
-rw-r--r-- wheel/wheel    3094 2020-07-06 09:18 ext/nokogiri/nokogiri.h
-rw-r--r-- wheel/wheel    2281 2020-07-06 09:18 ext/nokogiri/xml_attr.c
-rw-r--r-- wheel/wheel     137 2020-07-06 09:18 ext/nokogiri/xml_attr.h
-rw-r--r-- wheel/wheel    1428 2020-07-06 09:18 ext/nokogiri/xml_attribute_decl.c
-rw-r--r-- wheel/wheel     176 2020-07-06 09:18 ext/nokogiri/xml_attribute_decl.h
-rw-r--r-- wheel/wheel    1516 2020-07-06 09:18 ext/nokogiri/xml_cdata.c
-rw-r--r-- wheel/wheel     141 2020-07-06 09:18 ext/nokogiri/xml_cdata.h
-rw-r--r-- wheel/wheel    1703 2020-07-06 09:18 ext/nokogiri/xml_comment.c
-rw-r--r-- wheel/wheel     149 2020-07-06 09:18 ext/nokogiri/xml_comment.h
-rw-r--r-- wheel/wheel   15713 2020-07-06 09:18 ext/nokogiri/xml_document.c
-rw-r--r-- wheel/wheel     705 2020-07-06 09:18 ext/nokogiri/xml_document.h
-rw-r--r-- wheel/wheel    1105 2020-07-06 09:18 ext/nokogiri/xml_document_fragment.c
-rw-r--r-- wheel/wheel     189 2020-07-06 09:18 ext/nokogiri/xml_document_fragment.h
-rw-r--r-- wheel/wheel    4133 2020-07-06 09:18 ext/nokogiri/xml_dtd.c
-rw-r--r-- wheel/wheel     134 2020-07-06 09:18 ext/nokogiri/xml_dtd.h
-rw-r--r-- wheel/wheel    2595 2020-07-06 09:18 ext/nokogiri/xml_element_content.c
-rw-r--r-- wheel/wheel     218 2020-07-06 09:18 ext/nokogiri/xml_element_content.h
-rw-r--r-- wheel/wheel    1373 2020-07-06 09:18 ext/nokogiri/xml_element_decl.c
-rw-r--r-- wheel/wheel     168 2020-07-06 09:18 ext/nokogiri/xml_element_decl.h
-rw-r--r-- wheel/wheel    1740 2020-07-06 09:18 ext/nokogiri/xml_encoding_handler.c
-rw-r--r-- wheel/wheel     142 2020-07-06 09:18 ext/nokogiri/xml_encoding_handler.h
-rw-r--r-- wheel/wheel    2660 2020-07-06 09:18 ext/nokogiri/xml_entity_decl.c
-rw-r--r-- wheel/wheel     165 2020-07-06 09:18 ext/nokogiri/xml_entity_decl.h
-rw-r--r-- wheel/wheel    1189 2020-07-06 09:18 ext/nokogiri/xml_entity_reference.c
-rw-r--r-- wheel/wheel     184 2020-07-06 09:18 ext/nokogiri/xml_entity_reference.h
-rw-r--r-- wheel/wheel    1255 2020-07-06 09:18 ext/nokogiri/xml_io.c
-rw-r--r-- wheel/wheel     257 2020-07-06 09:18 ext/nokogiri/xml_io.h
-rw-r--r-- wheel/wheel    2971 2020-07-06 09:18 ext/nokogiri/xml_libxml2_hacks.c
-rw-r--r-- wheel/wheel     258 2020-07-06 09:18 ext/nokogiri/xml_libxml2_hacks.h
-rw-r--r-- wheel/wheel    2516 2020-07-06 09:18 ext/nokogiri/xml_namespace.c
-rw-r--r-- wheel/wheel     299 2020-07-06 09:18 ext/nokogiri/xml_namespace.h
-rw-r--r-- wheel/wheel   43736 2020-07-06 09:18 ext/nokogiri/xml_node.c
-rw-r--r-- wheel/wheel     305 2020-07-06 09:18 ext/nokogiri/xml_node.h
-rw-r--r-- wheel/wheel   12120 2020-07-06 09:18 ext/nokogiri/xml_node_set.c
-rw-r--r-- wheel/wheel     377 2020-07-06 09:18 ext/nokogiri/xml_node_set.h
-rw-r--r-- wheel/wheel    1336 2020-07-06 09:18 ext/nokogiri/xml_processing_instruction.c
-rw-r--r-- wheel/wheel     208 2020-07-06 09:18 ext/nokogiri/xml_processing_instruction.h
-rw-r--r-- wheel/wheel   14471 2020-07-06 09:18 ext/nokogiri/xml_reader.c
-rw-r--r-- wheel/wheel     146 2020-07-06 09:18 ext/nokogiri/xml_reader.h
-rw-r--r-- wheel/wheel    3660 2020-07-06 09:18 ext/nokogiri/xml_relax_ng.c
-rw-r--r-- wheel/wheel     152 2020-07-06 09:18 ext/nokogiri/xml_relax_ng.h
-rw-r--r-- wheel/wheel    8544 2020-07-06 09:18 ext/nokogiri/xml_sax_parser.c
-rw-r--r-- wheel/wheel     841 2020-07-06 09:18 ext/nokogiri/xml_sax_parser.h
-rw-r--r-- wheel/wheel    5736 2020-07-06 09:18 ext/nokogiri/xml_sax_parser_context.c
-rw-r--r-- wheel/wheel     192 2020-07-06 09:18 ext/nokogiri/xml_sax_parser_context.h
-rw-r--r-- wheel/wheel    3683 2020-07-06 09:18 ext/nokogiri/xml_sax_push_parser.c
-rw-r--r-- wheel/wheel     180 2020-07-06 09:18 ext/nokogiri/xml_sax_push_parser.h
-rw-r--r-- wheel/wheel    5391 2020-07-06 09:18 ext/nokogiri/xml_schema.c
-rw-r--r-- wheel/wheel     145 2020-07-06 09:18 ext/nokogiri/xml_schema.h
-rw-r--r-- wheel/wheel    1788 2020-07-06 09:18 ext/nokogiri/xml_syntax_error.c
-rw-r--r-- wheel/wheel     359 2020-07-06 09:18 ext/nokogiri/xml_syntax_error.h
-rw-r--r-- wheel/wheel    1143 2020-07-06 09:18 ext/nokogiri/xml_text.c
-rw-r--r-- wheel/wheel     138 2020-07-06 09:18 ext/nokogiri/xml_text.h
-rw-r--r-- wheel/wheel    7695 2020-07-06 09:18 ext/nokogiri/xml_xpath_context.c
-rw-r--r-- wheel/wheel     311 2020-07-06 09:18 ext/nokogiri/xml_xpath_context.h
-rw-r--r-- wheel/wheel    7420 2020-07-06 09:18 ext/nokogiri/xslt_stylesheet.c
-rw-r--r-- wheel/wheel     292 2020-07-06 09:18 ext/nokogiri/xslt_stylesheet.h
@flavorjones flavorjones added this to the v1.11.0 milestone Oct 14, 2020
@flavorjones flavorjones added help wanted release-blocker Blocking a milestone release labels Dec 1, 2020
@flavorjones
Copy link
Member Author

Hmm. After some thought, it's helpful to have the C extension files present as extra_rdoc_files, and they compress down to about 43KB which isn't much compared to the size of the 5.6MB gemfile. I'm going to close this and not actually do it, to preserve the local rdoc experience and avoid surprise.

@flavorjones flavorjones removed help wanted release-blocker Blocking a milestone release labels Dec 23, 2020
@flavorjones flavorjones removed this from the v1.11.0 milestone Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant