Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please drop the pkg-config dependency from the precompiled gems #1496

Closed
voxik opened this issue Jun 24, 2016 · 3 comments
Closed

Please drop the pkg-config dependency from the precompiled gems #1496

voxik opened this issue Jun 24, 2016 · 3 comments
Milestone
1.6.8.1

Comments

@voxik
Copy link
Contributor

voxik commented Jun 24, 2016

Not sure if that is possible, but there is no reason the precompiled versions of gem should depend on pkg-config. The java version does not depend on it, so hopefully this dependency can be avoided also for the other platforms.
@flavorjones
Copy link
Member

There's another issue opened objecting to the license, and so we may remove
it entirely. Stay tuned.
On Jun 24, 2016 9:14 AM, "Vít Ondruch" notifications@github.com wrote:

Not sure if that is possible, but there is no reason the precompiled
versions of gem should depend on pkg-config. The java version does not
depend on it, so hopefully this dependency can be avoided also for the
other platforms.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1496, or mute the
thread
https://github.com/notifications/unsubscribe/AAAgD68H--rrqthcOmOs5b_yp3jm2aIHks5qO9gqgaJpZM4I9wOo
.

@md5
Copy link

md5 commented Jun 24, 2016

@voxik The other issue is #1488

larskanis added a commit to larskanis/nokogiri that referenced this issue Jun 25, 2016
@larskanis
Make the pkg-config gem optional.
8e7c5f6 
Using the pkg-config gem as a runtime dependency of nokogiri results in a
license conflict. pkg-config is LGPL but nokogiri is MIT.

Making the pkg-config gem optional solves this issue.

Fixes sparklemotion#1488 and sparklemotion#1496 .
@larskanis larskanis mentioned this issue Jun 25, 2016
Closed
@flavorjones flavorjones added this to the 1.6.9 milestone Oct 3, 2016
flavorjones pushed a commit that referenced this issue Oct 3, 2016
@larskanis @flavorjones
Make the pkg-config gem optional.
aa154fc 
Using the pkg-config gem as a runtime dependency of nokogiri results in a
license conflict. pkg-config is LGPL but nokogiri is MIT.

Making the pkg-config gem optional solves this issue.

Fixes #1488 and #1496 .
flavorjones pushed a commit that referenced this issue Oct 3, 2016
@larskanis @flavorjones
Make the pkg-config gem optional.
f2dd079 
Using the pkg-config gem as a runtime dependency of nokogiri results in a
license conflict. pkg-config is LGPL but nokogiri is MIT.

Making the pkg-config gem optional solves this issue.

Fixes #1488 and #1496 .
@flavorjones
Copy link
Member

Will be fixed in 1.6.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.8.1
Development

No branches or pull requests
3 participants
@flavorjones @voxik @md5