Support is broken for Ruby 1.9.2

[mdchaney]

The issue is on line 77 of extconf.rb:

https://github.com/sparklemotion/nokogiri/blob/master/ext/nokogiri/extconf.rb#L77

if try_compile("int main() {return 0;}", '', werror: true)

"try_compile" takes two arguments and a block:

def try_compile(src, opt="", &b)
  try_do(src, cc_command(opt), &b)
ensure
  rm_f "conftest*"
end

This seems consistent throughout Ruby 1.9.2. In 1.9.3 there's a change:

def try_compile(src, opt="", *opts, &b)
  with_werror(opt, *opts) {|_opt, *_opts| try_do(src, cc_command(_opt), *_opts, &b)}
ensure
  rm_f "conftest*"
end

Removing the last argument lets compilation proceed in 1.9.2.

[nirvdrum]

This broke starting in nokogiri 1.6.4.1. 1.6.4 installs just fine. I don't think the Ubuntu version matters much. I'm seeing the same issue with 14.04.1.

[knu]

I wasn't even aware nokogiri should support ruby 1.9.2 because our README.rdoc states it requires 1.9.3 or higher. 1.9.2 had been reached its end of life as of about half a year ago, so I think we should fix the gemspec instead...

[knu]

Or, someone could make a monkey-patch for try_compile() of 1.9.2 and we'd be happy to merge it.

[nirvdrum]

I wasn't aware 1.9.2 wasn't supported. Thanks for the info. For me, the failure started when a gem I maintain that does support 1.9.2 got a newer version of nokogiri on Travis. Dropping 1.9.2 is probably fine, but I think doing it in a point release is a bit harsh. This broke in a patch release.

I'll look into the monkey-patching.

[mdchaney]

gemspec needs to be updated, then, as that's what I was looking at to determine lowest Ruby version. I agree there's no pressing reason to support an abandoned Ruby version but the gemspec should contain proper information.

[knu]

This was really an unfortunate situation. Actually the code I put in 1.6.4 already assumed the minimum requirement of ruby >=1.9.3, which unfortunately had a bug which was then fixed in 1.6.4.1. I dropped 1.9.2 from our Travis-CI configuration around mid-2013, so we don't even know if nokogiri has been working fine with ruby 1.9.2 since then.

I've just raised the minimum requirement for ruby to 1.9.3 for consistency, but I fully understand it may be harsh to drop support in a patch release. So, please feel free to submit a monkey patch and I'll put it in recovering the required_ruby_version for the next patch release. Thank you!

[flavorjones]

The breaking commit is 2054448.

[nirvdrum]

Thanks for calling that out. I saw GitHub linked to my comment, but it's been drowned out. Unfortunately, I've just started a new job and haven't managed to scrounge together the time to fix this.

[flavorjones]

This will be fixed in v1.6.6.

Note, however, I've officially proposed ending support for Ruby 1.9.2 as of Nokogiri 1.7.0 in #1227.

[mdchaney]

Thanks to all for the good work on this.