Skip to content

Commit

Permalink
ci: update some containers and versions of ruby (#3240)
Browse files Browse the repository at this point in the history
**What problem is this PR intended to solve?**

- use ruby 3.3 for some downstream projects
- use ruby 3.3 for upstream xmlsoft-head-valgrind job


Note: an early version of this PR updated ubuntu 24.04 for upstream
ruby-head-valgrind job, and that failed because some of the stack frames
had no information.
  • Loading branch information
flavorjones authored Jun 20, 2024
2 parents 0390ae2 + 67b0152 commit b32c542
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,15 @@ jobs:
- url: https://github.com/flavorjones/loofah
name: loofah
command: "bundle exec rake test"
ruby: "3.2"
ruby: "3.3"
- url: https://github.com/rails/rails-html-sanitizer
name: rails-html-sanitizer
command: "bundle exec rake test"
ruby: "3.2"
ruby: "3.3"
- url: https://github.com/rgrove/sanitize
name: sanitize
command: "bundle exec rake test"
ruby: "3.2"
ruby: "3.3"
- url: https://github.com/ebeigarts/signer
name: signer
command: "bundle exec rake spec"
Expand All @@ -47,7 +47,7 @@ jobs:
- url: https://github.com/rails/rails
name: xmlmini
command: "cd activesupport && bundle exec rake test TESTOPTS=-n/XmlMini/"
ruby: "3.2"
ruby: "3.3"
- url: https://github.com/pythonicrubyist/creek
name: creek
command: "bundle exec rake spec"
Expand All @@ -59,11 +59,11 @@ jobs:
- url: https://github.com/sparklemotion/mechanize
name: mechanize
command: "bundle exec rake test"
ruby: "3.2"
ruby: "3.3"
- url: https://github.com/stimulusreflex/stimulus_reflex
name: stimulus_reflex
command: "bundle exec rake test"
ruby: "3.2"
ruby: "3.3"
# - url: https://github.com/instructure/nokogiri-xmlsec-instructure
# name: nokogiri-xmlsec-instructure
# precommand: "apt install -y libxmlsec1-dev"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
xmlsoft-head-valgrind:
runs-on: ubuntu-latest
container:
image: ghcr.io/sparklemotion/nokogiri-test:mri-3.1
image: ghcr.io/sparklemotion/nokogiri-test:mri-3.3
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
fail-fast: false
matrix:
sys: ["enable", "disable"]
runs-on: ubuntu-20.04 # warning that 22.04 binary has dwarf5 debug info that valgrind can't read
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
Expand Down

0 comments on commit b32c542

Please sign in to comment.