Skip to content

Commit

Permalink
Merge pull request #2618 from sparklemotion/flavorjones-loosen-bundle…
Browse files Browse the repository at this point in the history
…r-dependency

ci: fix development dependency breakage
  • Loading branch information
flavorjones authored Aug 8, 2022
2 parents 8158f9a + 952d9e4 commit afe634a
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
with:
ruby-version: "3.0" # OK for now, until ruby 3.1 CI is stable
bundler-cache: true
bundler: latest
- run: bundle exec rake gumbo:test

basic:
Expand Down Expand Up @@ -219,6 +220,7 @@ jobs:
with:
ruby-version: ${{matrix.ruby}}
bundler-cache: true
bundler: latest
- uses: actions/cache@v2
if: matrix.sys == 'disable'
with:
Expand Down Expand Up @@ -248,6 +250,7 @@ jobs:
ruby-version: "${{matrix.ruby}}"
mingw: "libxml2 libxslt"
bundler-cache: true
bundler: latest
- uses: actions/cache@v2
if: matrix.sys == 'disable'
with:
Expand All @@ -271,6 +274,7 @@ jobs:
with:
ruby-version: ${{matrix.ruby}}
bundler-cache: true
bundler: latest
- run: bundle exec rake compile
- run: bundle exec rake test
- run: bundle exec rake test:bench
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/gem-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
with:
ruby-version: "3.1"
bundler-cache: true
bundler: latest
- id: rcd_image_version
run: bundle exec ruby -e 'require "rake_compiler_dock"; puts "::set-output name=rcd_image_version::#{RakeCompilerDock::IMAGE_VERSION}"'

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/generate-ci-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
with:
ruby-version: "3.1"
bundler-cache: true
bundler: latest
- uses: docker/setup-buildx-action@v1
- uses: docker/login-action@v1
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ jobs:
apt-get: "libxml2-dev libxslt1-dev pkg-config"
mingw: "_upgrade_ libxml2 libxslt pkgconf"
bundler-cache: true
bundler: latest
- uses: actions/cache@v2
if: matrix.sys == 'disable'
with:
Expand All @@ -107,6 +108,7 @@ jobs:
ruby-version: "head"
apt-get: "libxml2-dev libxslt1-dev pkg-config valgrind"
bundler-cache: true
bundler: latest
- uses: actions/cache@v2
if: matrix.sys == 'disable'
with:
Expand All @@ -125,6 +127,7 @@ jobs:
with:
ruby-version: "jruby-head"
bundler-cache: true
bundler: latest
- run: bundle exec rake compile
- run: bundle exec rake test

Expand Down
5 changes: 4 additions & 1 deletion nokogiri.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,10 @@ Gem::Specification.new do |spec|
spec.rdoc_options = ["--main", "README.md"]

if java_p
spec.add_development_dependency("jar-dependencies", "~> 0.4.1")
# loosen after jruby fixes https://github.com/jruby/jruby/issues/7262
# also see https://github.com/mkristian/jar-dependencies/commit/006fb254
spec.add_development_dependency("jar-dependencies", "= 0.4.1")

spec.require_paths << "lib/nokogiri/jruby" # where we install the jars, see the :vendor_jars rake task
spec.requirements << "jar isorelax, isorelax, 20030108" # https://search.maven.org/artifact/isorelax/isorelax
spec.requirements << "jar org.nokogiri, nekodtd, 0.1.11.noko1"
Expand Down
1 change: 1 addition & 0 deletions rakelib/docker.rake
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ module DockerHelper
with:
ruby-version: "3.1"
bundler-cache: true
bundler: latest
- uses: docker/setup-buildx-action@v1
- uses: docker/login-action@v1
with:
Expand Down

0 comments on commit afe634a

Please sign in to comment.