Skip to content

Commit

Permalink
Remove outdated comments
Browse files Browse the repository at this point in the history
The first comment is incorrect. The fragment case was changed to match
the nonfragment case in whatwg/html#6399.

This introduced a bug that was noted by the second comment indicating
that the parser diverged from the standard to fix the bug. The standard
was subsequently fixed in whatwg/html#6455,
obviating the comment.
  • Loading branch information
stevecheckoway committed Oct 13, 2021
1 parent 657e31f commit 9727445
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions gumbo-parser/src/parser.c
Original file line number Diff line number Diff line change
Expand Up @@ -4423,11 +4423,6 @@ static void handle_in_foreign_content(GumboParser* parser, GumboToken* token) {
/* Parse error */
parser_add_parse_error(parser, token);

/*
* Fragment case: If the parser was originally created for the HTML
* fragment parsing algorithm, then act as described in the "any other
* start tag" entry below.
*/
while (
!(
is_mathml_integration_point(get_current_node(parser))
Expand All @@ -4437,12 +4432,6 @@ static void handle_in_foreign_content(GumboParser* parser, GumboToken* token) {
) {
pop_current_node(parser);
}
// XXX: The spec currently says to handle this using the in body insertion
// mode rules. That seems wrong. See
// <https://github.com/whatwg/html/issues/6808>. Instead, use the current
// insertion mode which seems like it works.
//
// handle_in_body(parser, token);
handle_html_content(parser, token);
return;
}
Expand Down

0 comments on commit 9727445

Please sign in to comment.