Skip to content

Commit

Permalink
tweak compiler flags to reduce noise
Browse files Browse the repository at this point in the history
remove a few that generate lots of warnings on ruby.h:
- -Wcast-qual
- -Wconversion

add -Wextra back (it was removed in 2008)
  • Loading branch information
flavorjones committed Mar 4, 2018
1 parent b5b97bc commit 77be60c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext/nokogiri/extconf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ def using_system_libraries?

if RbConfig::MAKEFILE_CONFIG['CC'] =~ /gcc/
$CFLAGS << " -O3" unless $CFLAGS[/-O\d/]
$CFLAGS << " -Wall -Wcast-qual -Wwrite-strings -Wconversion -Wmissing-noreturn -Winline"
$CFLAGS << " -Wall -Wextra -Wwrite-strings -Wmissing-noreturn -Winline"
end

case
Expand Down

0 comments on commit 77be60c

Please sign in to comment.