Fix ref counting and originToWorld in SparkViewpoint.prepare
#207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #205
The
preparemethod ofSparkViewpointincreased therefCountof the active accumulator in case it wasn't used in the viewpoint's display state. However the display reference is already covered, resulting in double counting this reference. At the same time there's no guarantee the viewpoint holds any reference whensortUpdateis called. To resolve this a temporary reference is held.Additionally there was a bug where the
preparemethod would default to not providing anoriginToWorldmatrix. This causes theSparkRendererto use the currenttoWorldof the active accumulator. This works as long as theSparkRendererhasn't been moved, but renders incorrectly in case it did. See following scenario:One thing that remains tricky with regards to
prepareis that it directly callssortUpdate, ignoring any ongoing sort operation or pending sort operation. This makes it possible forsortUpdateto throw an error, breaking the ref counting.