Readregion api change #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push changes to working branch.
Merge over.
merge main to adderr
Returns a proper error code now. ReadBytes returns number of bytes read.
…parkFun_Toolkit into readregion_api_change
|
This matches most implementations of modern I2C devices. By sending a stop command after sending the device register address rather than a repeat start, you end the transaction early and leave the bus in an odd state. This corrects this and also corrects how the continued read of values in the In ADS1219 datasheet: In AS7331 datasheet: In my experience this is the default behavior, and less capable devices should |
Add include directive.
PaulZC
previously requested changes
Dec 14, 2023
Add to docs for pointing out enabling repeat start.
|
Should we use |
PaulZC
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in gitignore and gitattributes files.
Rework readRegisterRegion to return error type and have an output argument for the number of bytes read.
Makes default stop value false so as to not send a stop mid-read.
Make readRegisterRegion take in a reference rather than a pointer.
Rev to 0.9.0.