Skip to content

Change swap def to swapOLED, to avoid problems with some platforms #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

bryanmtdt
Copy link
Contributor

ESP32 platform had problems to compile with the MicroOLED because it already have a swap function.
xtensa-esp32-elf/include/c++/5.2.0/bits/exception_ptr.h

The swapOLED worked fine on the ESP32 thing (cube test)

@jimblom jimblom merged commit 4c4b7f0 into sparkfun:master Jun 25, 2018
@jimblom
Copy link
Contributor

jimblom commented Jun 25, 2018

This looks good. swapOLED doesn't really need to be exposed in the header file, so I'm going to move it to the cpp.

Thanks for contributing! Sorry for the slow response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants