Skip to content

Increase pullup resistor on RX pin #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Increase pullup resistor on RX pin #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libraries/SoftwareSerial/src/SoftwareSerial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,13 @@ void SoftwareSerial::begin(uint32_t baudRate, HardwareSerial_Config_e SSconfig)

pinMode(_rxPin, INPUT);
if (_invertLogic == false)
pinMode(_rxPin, INPUT_PULLUP); //Enable external pullup if using normal logic
{
//Enable external pullup if using normal logic
//On some GPIO the g_AM_HAL_GPIO_INPUT_PULLUP seems to be strong enough
//to cause problems translation buffers like the TXB0104. Limiting
//to 24k fixing issue.
pinMode(_rxPin, g_AM_HAL_GPIO_INPUT_PULLUP_24);
}

#ifdef DEBUG
am_hal_gpio_output_clear(debugPad);
Expand Down