Skip to content

refs #0000 Add new output #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

osvaldot
Copy link
Member

@osvaldot osvaldot commented Feb 28, 2025

PR Type

Enhancement


Description

  • Added new output managed_node_groups to expose attributes of all EKS managed node groups
  • Updated CHANGELOG.md with version 4.1.0 details
  • Updated Fluentbit module to version 0.4.0
  • Fixed documentation typo

Changes walkthrough 📝

Relevant files
Enhancement
outputs.tf
Add managed node groups output variable                                   

outputs.tf

  • Added new output managed_node_groups to expose EKS managed node groups
    attributes
  • +3/-0     
    Documentation
    CHANGELOG.md
    Update changelog for version 4.1.0                                             

    CHANGELOG.md

  • Added version 4.1.0 changelog entry
  • Documented new managed_node_groups output
  • Updated Fluentbit module version information
  • Fixed typo in "Fluntbit" to "Fluentbit"
  • +10/-1   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @sparkfabrik-ai-bot
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 Security concerns

    Sensitive information exposure:
    The new managed_node_groups output exposes the complete node group configuration which may contain sensitive information like IAM roles, security group IDs, or instance configuration details. Consider marking this output as sensitive or limiting the exposed attributes to only those that are safe to expose.

    ⚡ Recommended focus areas for review

    Sensitive Data

    The new output exposes all node group attributes without marking them as sensitive, which could expose sensitive configuration details

    output "managed_node_groups" {
      value = module.eks.eks_managed_node_groups
    }

    @sparkfabrik-ai-bot
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Security
    Mark sensitive outputs as such to prevent accidental exposure of confidential infrastructure details

    Add the 'sensitive = true' attribute to the managed_node_groups output as it may
    contain sensitive information about the EKS node groups configuration

    outputs.tf [39-41]

     output "managed_node_groups" {
    +  sensitive = true
       value = module.eks.eks_managed_node_groups
     }
    Suggestion importance[1-10]: 9

    Why: The suggestion addresses a significant security concern by marking node group details as sensitive, preventing accidental exposure of infrastructure configuration in logs or outputs. This is particularly important for EKS node groups which may contain sensitive operational details.

    9

    @filippolmt filippolmt self-requested a review February 28, 2025 12:49
    @osvaldot osvaldot merged commit 19ad119 into main Feb 28, 2025
    1 check passed
    @osvaldot osvaldot deleted the 0000-add-new-aoutput-managed_node_groups branch February 28, 2025 13:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants