Skip to content

Conversation

@supercontracts
Copy link
Collaborator

@supercontracts supercontracts commented Nov 11, 2025

Summary by CodeRabbit

  • Chores
    • Updated production configuration files to add rate limiting and ALM proxy support across multiple blockchain networks.

deluca-mike and others added 3 commits November 10, 2025 11:55
* feat: AAVE external lib and Approve internal lib

- cuts down on much needed contract size for future integrations

* fix: PR Review
@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

Four production configuration JSON files are updated to include two new fields (rateLimits and almProxy) to each network configuration. Existing entries are preserved, with formatting adjustments made to accommodate the additions.

Changes

Cohort / File(s) Summary
Configuration field additions
script/input/1/arbitrum_one-production.json, script/input/1/avalanche-production.json, script/input/1/optimism-production.json, script/input/1/unichain-production.json
Added two new top-level JSON fields (rateLimits and almProxy) to each network configuration file with corresponding Ethereum addresses. Existing fields retained with trailing comma adjustments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • All changes follow an identical, repetitive pattern across four configuration files
  • No logic, behavioral, or structural changes; purely configuration data additions
  • Homogeneous edits with minimal cognitive overhead per file

Poem

🐰 A rabbit hops through configs bright,
Adding fields left and right,
Limits and proxies, all in place,
Four networks running at a pace!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows the required format with 'feat:' prefix and clearly describes the main change: adding ALM_PROXY and RATE_LIMITS addresses to deploy JSON configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/add-addresses-to-deploy-json

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 241b131 and f535468.

📒 Files selected for processing (4)
  • script/input/1/arbitrum_one-production.json (1 hunks)
  • script/input/1/avalanche-production.json (1 hunks)
  • script/input/1/optimism-production.json (1 hunks)
  • script/input/1/unichain-production.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: coverage
  • GitHub Check: test
🔇 Additional comments (4)
script/input/1/unichain-production.json (1)

9-11: Field order is correct and JSON syntax is valid.

The two new fields are properly added with valid Ethereum address formats and correct JSON punctuation.

script/input/1/arbitrum_one-production.json (1)

9-11: Field order is inconsistent with other networks.

Lines 10-11 have almProxy before rateLimits, whereas all other production JSONs (unichain, avalanche, optimism) follow the order rateLimits then almProxy. This could indicate a copy-paste error or inconsistent manual updates.

Verify whether field order matters for schema validation or runtime behavior. If field order should be consistent across all networks for maintainability, please align arbitrum_one with the other three files.

script/input/1/avalanche-production.json (1)

7-9: Field order is correct and JSON syntax is valid.

The two new fields follow the expected rateLimits then almProxy order, consistent with unichain and optimism. All addresses are properly formatted.

script/input/1/optimism-production.json (1)

9-11: Field order is correct and JSON syntax is valid.

The two new fields follow the expected rateLimits then almProxy order, consistent with unichain and avalanche. All addresses are properly formatted.


Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Nov 11, 2025
@github-actions
Copy link

Coverage after merging feat/add-addresses-to-deploy-json into dev will be

99.55%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
deploy
   ControllerDeploy.sol100%100%100%100%
   ForeignControllerInit.sol100%100%100%100%
   MainnetControllerInit.sol97.37%93.33%100%100%152, 90
src
   ALMProxy.sol100%100%100%100%
   ALMProxyFreezable.sol100%100%100%100%
   ForeignController.sol98.24%91.67%100%99.16%312–313, 613
   MainnetController.sol99.11%100%98.11%99.18%500–501
   OTCBuffer.sol100%100%100%100%
   RateLimitHelpers.sol100%100%100%100%
   RateLimits.sol100%100%100%100%
src/libraries
   AaveLib.sol100%100%100%100%
   ApproveLib.sol100%100%100%100%
   CCTPLib.sol100%100%100%100%
   CurveLib.sol100%100%100%100%
   ERC4626Lib.sol96%75%100%100%108
   PSMLib.sol100%100%100%100%

deluca-mike
deluca-mike previously approved these changes Nov 14, 2025
@lucas-manuel lucas-manuel dismissed stale reviews from deluca-mike and coderabbitai[bot] November 18, 2025 12:47

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants